Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing yamls in controllers/nginx #1270

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

harryge00
Copy link
Contributor

@harryge00 harryge00 commented Aug 30, 2017

examples/ingress.yaml and examples/default/rc-default.yaml are missing. And I did not find the latter...

Add default-backend.yaml because it is used.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Aug 30, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 30, 2017
@harryge00 harryge00 force-pushed the add-yaml-to-nginx-controller branch from 111f607 to 4e1ae0e Compare August 30, 2017 07:23
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 30, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.613% when pulling 4e1ae0efb7bae2d20b1cfca20d518697fb486419 on harryge00:add-yaml-to-nginx-controller into 2d6f811 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.613% when pulling 4e1ae0efb7bae2d20b1cfca20d518697fb486419 on harryge00:add-yaml-to-nginx-controller into 2d6f811 on kubernetes:master.

@harryge00 harryge00 force-pushed the add-yaml-to-nginx-controller branch from 4e1ae0e to 6dd1b0b Compare August 30, 2017 08:21
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 43.588% when pulling 6dd1b0b on harryge00:add-yaml-to-nginx-controller into 2d6f811 on kubernetes:master.

@aledbf aledbf self-assigned this Aug 30, 2017
@aledbf
Copy link
Member

aledbf commented Aug 30, 2017

@harryge00 thanks!

@aledbf aledbf merged commit 2d7f6c5 into kubernetes:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants